Skip to content

Comments

Try to fix codecov upload permissions for forks#3533

Open
oalders wants to merge 2 commits intomasterfrom
oalders/fix-permissions
Open

Try to fix codecov upload permissions for forks#3533
oalders wants to merge 2 commits intomasterfrom
oalders/fix-permissions

Conversation

@oalders
Copy link
Member

@oalders oalders commented Feb 24, 2026

  • Don't try to upload to codecov if the token is not available
  • Try to upload codedov reports even if forked branches

Forks won't have access to the token. Rather than allowing tokenless
uploads for everyone, we run it in a different workflow which hopefully
does have the token.
@haarg
Copy link
Member

haarg commented Feb 25, 2026

This is essentially the same this I was trying to do in #3084 but didn't get working.

@oalders
Copy link
Member Author

oalders commented Feb 25, 2026

The other option would be to allow coverage uploads from forks without requiring a key. Or we forego coverage reports on forks. Given how few PRs we get from forks I guess this is probably not worth spending a lot of time on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants